-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24084/
-----------------------------------------------------------
(Updated July 30, 2014, 11:40 p.m.)
Review request for hive.
Changes
-------
Incorporating Brock and Thejas review comments. As Thejas pointed out, turns
out ipAddress is already stored in sessionState, so using that and code becomes
a lot cleaner.
However, the ipAddress calculated in TSetIpAddressProcessor doesnt work in
kerberos mode, so fixing it so its set in all modes.
Bugs: HIVE-7547
https://issues.apache.org/jira/browse/HIVE-7547
Repository: hive-git
Description
-------
Passing the ipAddress and userName (already calculated in ThriftCLIService for
other purposes) through several layers down to the hooks.
Diffs (updated)
-----
itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHs2HooksWithMiniKdc.java
PRE-CREATION
itests/hive-unit/src/test/java/org/apache/hadoop/hive/hooks/TestHs2Hooks.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/Driver.java e512199
ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java b11cb86
service/src/java/org/apache/hive/service/cli/CLIService.java add37a1
service/src/java/org/apache/hive/service/cli/session/HiveSession.java 9785e95
service/src/java/org/apache/hive/service/cli/session/SessionManager.java
816bea4
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
5c87bcb
Diff: https://reviews.apache.org/r/24084/diff/
Testing
-------
Added tests in both kerberos and non-kerberos mode.
Thanks,
Szehon Ho
