[ 
https://issues.apache.org/jira/browse/HIVE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079216#comment-14079216
 ] 

Lars Francke commented on HIVE-7390:
------------------------------------

As noted in my review I'm not too sure about adding another format especially 
if it's called "quotedCSV" because that implies that the others aren't using 
quoting but they actually are when needed.

The old way sometimes produces invalid CSV (when quoting or delimiter chars 
exist in the data) so I think it's a good idea to fix this (and super-csv seems 
to solve that). I'm not sure if preserving the old functionality is worth 
anything. And if you do then maybe deprecate it and name it `deprecatedCSV` or 
something like that.

I'd be in favor of two options instead (similar to what was suggested 
originally)
* Delimiter
* Quoting character

Maybe even a third: Quoting mode. I'm in favor of always adding quotes as it 
makes parsing easier (no need to check for quoted/unquoted columns etc.). If 
not adding that I'd vote in favor of changing the current quoting mode to the 
AllwaysQuote mode.

> Make quote character optional and configurable in BeeLine CSV/TSV output
> ------------------------------------------------------------------------
>
>                 Key: HIVE-7390
>                 URL: https://issues.apache.org/jira/browse/HIVE-7390
>             Project: Hive
>          Issue Type: New Feature
>          Components: Clients
>    Affects Versions: 0.13.1
>            Reporter: Jim Halfpenny
>            Assignee: Ferdinand Xu
>         Attachments: HIVE-7390.1.patch, HIVE-7390.2.patch, HIVE-7390.3.patch, 
> HIVE-7390.4.patch, HIVE-7390.patch
>
>
> Currently when either the CSV or TSV output formats are used in beeline each 
> column is wrapped in single quotes. Quote wrapping of columns should be 
> optional and the user should be able to choose the character used to wrap the 
> columns.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to