[ 
https://issues.apache.org/jira/browse/HIVE-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076742#comment-14076742
 ] 

Sushanth Sowmyan commented on HIVE-6584:
----------------------------------------

+1 on the patch.

The one thing I'd change before committing is a word-wrap for the ASF header in 
conf/hive-default.xml.template, to retain old newline behaviour there. But 
otherwise, looks good to me. 

We'll need to update those TODOs in a bit once we upgrade to a newer version of 
HBase (0.98.5+) to pick up HBASE-11555. I would have suggested doing that in 
this patch itself, given that you're already bumping version up to 0.98.3, 
except that I see that that got resolved only recently, and I don't want to 
drag this patch out any further. Could you please open another jira to track 
that TODO?

> Add HiveHBaseTableSnapshotInputFormat
> -------------------------------------
>
>                 Key: HIVE-6584
>                 URL: https://issues.apache.org/jira/browse/HIVE-6584
>             Project: Hive
>          Issue Type: Improvement
>          Components: HBase Handler
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>             Fix For: 0.14.0
>
>         Attachments: HIVE-6584.0.patch, HIVE-6584.1.patch, 
> HIVE-6584.10.patch, HIVE-6584.11.patch, HIVE-6584.12.patch, 
> HIVE-6584.2.patch, HIVE-6584.3.patch, HIVE-6584.4.patch, HIVE-6584.5.patch, 
> HIVE-6584.6.patch, HIVE-6584.7.patch, HIVE-6584.8.patch, HIVE-6584.9.patch
>
>
> HBASE-8369 provided mapreduce support for reading from HBase table snapsopts. 
> This allows a MR job to consume a stable, read-only view of an HBase table 
> directly off of HDFS. Bypassing the online region server API provides a nice 
> performance boost for the full scan. HBASE-10642 is backporting that feature 
> to 0.94/0.96 and also adding a {{mapred}} implementation. Once that's 
> available, we should add an input format. A follow-on patch could work out 
> how to integrate this functionality into the StorageHandler, similar to how 
> HIVE-6473 integrates the HFileOutputFormat into existing table definitions.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to