----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23738/#review48317 -----------------------------------------------------------
Hi Dong, can we make sure it is running as the connecting user, rather than the hiveserver2 user? I know it is a global .rc file and thus same commands, but I think it should be the connecting user for both security and auditing. For example, in the comment below, I think we should use proxySession to execute the statement if security is enabled. Everything else looks great. service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java <https://reviews.apache.org/r/23738/#comment84789> Is it possible to rework the order , so that we still use proxy Session? service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java <https://reviews.apache.org/r/23738/#comment84788> Small issue, can we fix the spelling for password? - Szehon Ho On July 21, 2014, 1:53 p.m., Dong Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23738/ > ----------------------------------------------------------- > > (Updated July 21, 2014, 1:53 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-5160: HS2 should support .hiverc > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/cli/HiveFileProcessor.java > PRE-CREATION > common/src/java/org/apache/hadoop/hive/common/cli/IHiveFileProcessor.java > PRE-CREATION > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8bff2a9 > conf/hive-default.xml.template 4944dfc > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > 6a7ee7a > > service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java > e79b129 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > 6650c05 > > service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/23738/diff/ > > > Testing > ------- > > UT passed. > > > Thanks, > > Dong Chen > >
