> On July 18, 2014, 1:57 p.m., Tom White wrote: > > ql/src/test/queries/clientpositive/avro_schema_evolution_native.q, line 25 > > <https://reviews.apache.org/r/23387/diff/9/?file=634606#file634606line25> > > > > It would be nice to support ALTER TABLE t ADD COLUMN ..., but that is > > an enhancement - file another JIRA for that?
Created HIVE-7446. > On July 18, 2014, 1:57 p.m., Tom White wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java, > > line 238 > > <https://reviews.apache.org/r/23387/diff/9/?file=634615#file634615line238> > > > > This should add to the start of the list. Also, needs a test for this > > case. This is actually unreachable code. removeDuplicateNullSchemas makes sure that null is at the beginning of the list. And there will never be a case that a union will be reach here without having a null. Added a couple of test cases to be sure. > On July 18, 2014, 1:57 p.m., Tom White wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java, line 112 > > <https://reviews.apache.org/r/23387/diff/9/?file=634614#file634614line112> > > > > Is it possible to default name to table name, namespace to database > > name, and doc to table comment? I was planning to do this, but slipped off my mind. Thanks for pointing this out. I don't think it is possible to retrieve database name inside serde. Addressed name and doc. - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23387/#review48120 ----------------------------------------------------------- On July 17, 2014, 9:10 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23387/ > ----------------------------------------------------------- > > (Updated July 17, 2014, 9:10 p.m.) > > > Review request for hive. > > > Bugs: HIVE-6806 > https://issues.apache.org/jira/browse/HIVE-6806 > > > Repository: hive-git > > > Description > ------- > > HIVE-6806: Native avro support > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/io/AvroStorageFormatDescriptor.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/io/IOConstants.java > 1bae0a8fee04049f90b16d813ff4c96707b349c8 > > ql/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor > a23ff115512da5fe3167835a88d582c427585b8e > ql/src/test/org/apache/hadoop/hive/ql/io/TestStorageFormatDescriptor.java > d53ebc65174d66bfeee25fd2891c69c78f9137ee > ql/src/test/queries/clientpositive/avro_compression_enabled_native.q > PRE-CREATION > ql/src/test/queries/clientpositive/avro_decimal_native.q PRE-CREATION > ql/src/test/queries/clientpositive/avro_joins_native.q PRE-CREATION > ql/src/test/queries/clientpositive/avro_native.q PRE-CREATION > ql/src/test/queries/clientpositive/avro_partitioned_native.q PRE-CREATION > ql/src/test/queries/clientpositive/avro_schema_evolution_native.q > PRE-CREATION > ql/src/test/results/clientpositive/avro_compression_enabled_native.q.out > PRE-CREATION > ql/src/test/results/clientpositive/avro_decimal_native.q.out PRE-CREATION > ql/src/test/results/clientpositive/avro_joins_native.q.out PRE-CREATION > ql/src/test/results/clientpositive/avro_native.q.out PRE-CREATION > ql/src/test/results/clientpositive/avro_partitioned_native.q.out > PRE-CREATION > ql/src/test/results/clientpositive/avro_schema_evolution_native.q.out > PRE-CREATION > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java > 0db12437406170686a21b6055d83156fe5d6a55f > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java > 1fe31e0034f8988d03a0c51a90904bb93e7cb157 > serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java > PRE-CREATION > serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/23387/diff/ > > > Testing > ------- > > Added qTests and unit tests > > > Thanks, > > Ashish Singh > >
