----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23482/#review48106 -----------------------------------------------------------
Ship it! Ship It! - Navis Ryu On July 15, 2014, 8:37 a.m., Damien Carol wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23482/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 8:37 a.m.) > > > Review request for hive. > > > Bugs: HIVE-7374 > https://issues.apache.org/jira/browse/HIVE-7374 > > > Repository: hive-git > > > Description > ------- > > HIVE-7374: SHOW COMPACTIONS fail on trunk > > In CLI in trunk after doing this : > {{show compactions;}} > Return error : > {noformat} > FAILED: Execution Error, return code 1 from > org.apache.hadoop.hive.ql.exec.DDLTask. > org.apache.thrift.transport.TTransportException > {noformat} > > In metatore : > {noformat} > 2014-07-09 17:54:10,537 ERROR [pool-3-thread-20]: server.TThreadPoolServer > (TThreadPoolServer.java:run(213)) - Thrift error occurred during processing > of message. > org.apache.thrift.protocol.TProtocolException: Required field 'compacts' is > unset! Struct:ShowCompactResponse(compacts:null) > at > org.apache.hadoop.hive.metastore.api.ShowCompactResponse.validate(ShowCompactResponse.java:310) > at > org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$show_compact_result.validate(ThriftHiveMetastore.java) > at > org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$show_compact_result$show_compact_resultStandardScheme.write(ThriftHiveMetastore.java) > at > org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$show_compact_result$show_compact_resultStandardScheme.write(ThriftHiveMetastore.java) > at > org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$show_compact_result.write(ThriftHiveMetastore.java) > at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:53) > at > org.apache.hadoop.hive.metastore.TUGIBasedProcessor.process(TUGIBasedProcessor.java:103) > at > org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:206) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > at java.lang.Thread.run(Thread.java:744) > {noformat} > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 7e8f3fe > > metastore/src/test/org/apache/hadoop/hive/metastore/txn/TestCompactionTxnHandler.java > 5d6f066 > ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestCleaner.java > dce2573 > ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestInitiator.java > 6b46822 > > Diff: https://reviews.apache.org/r/23482/diff/ > > > Testing > ------- > > Manual test with maven. > CLI test with patched version on real cluster. > > > Thanks, > > Damien Carol > >
