----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23253/#review47481 -----------------------------------------------------------
According to the sqlline doc on which beeline is based, it only mentions "Lines beginning with "#" are interpreted as comments and ignored". Interpreting inline "#" as comments will restrict us from writing queries which have "#" appearing in the query body. - Deepesh Khandelwal On July 4, 2014, 1 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23253/ > ----------------------------------------------------------- > > (Updated July 4, 2014, 1 a.m.) > > > Review request for hive. > > > Bugs: HIVE-7340 > https://issues.apache.org/jira/browse/HIVE-7340 > > > Repository: hive-git > > > Description > ------- > > HIVE-7340: Beeline fails to read a query with comments correctly > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/Commands.java > 88a94d76a3750dcde31ff47913bf28b827b3b212 > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java > 140c1bccedb9ef3c81e89026db44ce4b59150ef4 > > Diff: https://reviews.apache.org/r/23253/diff/ > > > Testing > ------- > > Added unit tests. > > > Thanks, > > Ashish Singh > >
