-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22926/
-----------------------------------------------------------
(Updated July 1, 2014, 8:43 a.m.)
Review request for hive.
Changes
-------
Check ambiguous columns & added negative tests
Bugs: HIVE-494
https://issues.apache.org/jira/browse/HIVE-494
Repository: hive-git
Description
-------
SELECT mytable[0], mytable[2] FROM some_table_name mytable;
...should return the first and third columns, respectively, from mytable
regardless of their column names.
The need for "names" specifically is kind of silly when they just get
translated into numbers anyway.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnInfo.java feb8558
ql/src/java/org/apache/hadoop/hive/ql/parse/FromClauseParser.g f448b16
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 9c001c1
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1d8d764
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java e7da289
ql/src/test/queries/clientnegative/select_by_column_index_negative0.q
PRE-CREATION
ql/src/test/queries/clientnegative/select_by_column_index_negative1.q
PRE-CREATION
ql/src/test/queries/clientnegative/select_by_column_index_negative2.q
PRE-CREATION
ql/src/test/queries/clientpositive/select_by_column_index.q PRE-CREATION
ql/src/test/results/clientnegative/select_by_column_index_negative0.q.out
PRE-CREATION
ql/src/test/results/clientnegative/select_by_column_index_negative1.q.out
PRE-CREATION
ql/src/test/results/clientnegative/select_by_column_index_negative2.q.out
PRE-CREATION
ql/src/test/results/clientpositive/select_by_column_index.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/22926/diff/
Testing
-------
Thanks,
Navis Ryu
