[
https://issues.apache.org/jira/browse/HIVE-6468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047890#comment-14047890
]
Ravi Prakash commented on HIVE-6468:
------------------------------------
Hi Navis! Thanks a lot for your patch! I'm glad at least someone is cognizant
of the severity of this problem. Do you think we should increase the priority
for this JIRA?
The patch looks good to me overall except for a few nits. FWIW, here they are:
HiveAuthFactory:
1. Could we just rewrite
authTypeStr.equalsIgnoreCase(AuthTypes.KERBEROS.name()) -> authType ==
AuthTypes.KERBEROS
2. You're catching Exception. Any reason you changed this from IOException?
IMHO IOException would have been preferable
3. This block is unnecessary {code} } else {
saslServer = null;
} {code}
4. getAuthTransFactory() is throwing Exception now. Why did you have to change
that from LoginException?
PlainSaslHelper:
1. public String mechanism; is never used
2. I'm not sure what the consequences of using WeakReferences and WeakHashMap
will be. Could you please comment on that?
3. Can we also put a timeout on {code}
underlyingTransport.readAll(messageHeader, 0, messageHeader.length); {code} if
there isn't one already?
> HS2 out of memory error when curl sends a get request
> -----------------------------------------------------
>
> Key: HIVE-6468
> URL: https://issues.apache.org/jira/browse/HIVE-6468
> Project: Hive
> Issue Type: Bug
> Affects Versions: 0.12.0
> Environment: Centos 6.3, hive 12, hadoop-2.2
> Reporter: Abin Shahab
> Assignee: Navis
> Attachments: HIVE-6468.1.patch.txt, HIVE-6468.2.patch.txt
>
>
> We see an out of memory error when we run simple beeline calls.
> (The hive.server2.transport.mode is binary)
> curl localhost:10000
> Exception in thread "pool-2-thread-8" java.lang.OutOfMemoryError: Java heap
> space
> at
> org.apache.thrift.transport.TSaslTransport.receiveSaslMessage(TSaslTransport.java:181)
> at
> org.apache.thrift.transport.TSaslServerTransport.handleSaslStartMessage(TSaslServerTransport.java:125)
> at
> org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:253)
> at
> org.apache.thrift.transport.TSaslServerTransport.open(TSaslServerTransport.java:41)
> at
> org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:216)
> at
> org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:189)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:744)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
