> On June 20, 2014, 11:52 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInFile.java, > > line 84 > > <https://reviews.apache.org/r/22772/diff/4/?file=614380#file614380line84> > > > > Same thing here about using getPrimitiveCategory() rather than > > class/class name. Sorry I missed this on the previous review.
That was my bad. Thanks for catching it. - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22772/#review46347 ----------------------------------------------------------- On June 21, 2014, 1:26 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22772/ > ----------------------------------------------------------- > > (Updated June 21, 2014, 1:26 a.m.) > > > Review request for hive. > > > Bugs: HIVE-6637 > https://issues.apache.org/jira/browse/HIVE-6637 > > > Repository: hive-git > > > Description > ------- > > HIVE-6637: UDF in_file() doesn't take CHAR or VARCHAR as input > > > HIVE-6637: UDF in_file() doesn't take CHAR or VARCHAR as input > > > HIVE-6637: UDF in_file() doesn't take CHAR or VARCHAR as input > > > HIVE-6637: UDF in_file() doesn't take CHAR or VARCHAR as input > > > HIVE-6637: UDF in_file() doesn't take CHAR or VARCHAR as input > > > Add unit tests for Udf in_file > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInFile.java > ea52537d0b85191f0b633a29aa3f7ddb556c288d > ql/src/test/queries/clientpositive/udf_in_file.q > 9d9efe8e23d6e73429ee5cd2c8470359ba2b3498 > ql/src/test/results/clientpositive/udf_in_file.q.out > b63143760d80f3f6a8ba0a23c0d87e8bb86fce66 > > Diff: https://reviews.apache.org/r/22772/diff/ > > > Testing > ------- > > Tested with qtest. > > > Thanks, > > Ashish Singh > >
