----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22804/ -----------------------------------------------------------
Review request for hive and Brock Noland. Repository: hive-git Description ------- This is for HIVE-6394 (parquet timestamp). There had been a review comment for not relying on example parquet classes, which are just suggestion of how to implement timestamp. It is trivial, just to implement that sample class in Hive code base. I had addressed it in one of the patch, but the next patch did not carry that on as I made a mistake. Addressing again now. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/ETypeConverter.java 73cf0f5 ql/src/java/org/apache/hadoop/hive/ql/io/parquet/timestamp/NanoTime.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/io/parquet/timestamp/NanoTimeUtils.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/io/parquet/utils/NanoTimeUtils.java 06987ad ql/src/java/org/apache/hadoop/hive/ql/io/parquet/write/DataWritableWriter.java 8bb9cb1 ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetTimestampUtils.java f56a643 Diff: https://reviews.apache.org/r/22804/diff/ Testing ------- Ran affected parquet timestamp tests. Thanks, Szehon Ho
