----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22770/#review46180 -----------------------------------------------------------
ql/src/test/queries/clientpositive/columnstats_partlvl_dp.q <https://reviews.apache.org/r/22770/#comment81448> I don't think these tests have enough coverage. For instance, as far as I can tell nothing validates that the stats computed are actually correct and that all col stats are populated. Some ideas are: - test with different data in different partitions - validate correctness of stats - run analyze without specifying any partition key (i suspect that would be the common case) - test with schema evolution (eg: what happens when we add a column/drop/rearrange columns and run a full table analyze - test with partially populated stats for a table (i.e.: incremental update stats scenario) Are these covered elsewhere? - Gunther Hagleitner On June 19, 2014, 2:35 a.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22770/ > ----------------------------------------------------------- > > (Updated June 19, 2014, 2:35 a.m.) > > > Review request for hive. > > > Bugs: HIVE-7255 > https://issues.apache.org/jira/browse/HIVE-7255 > > > Repository: hive-git > > > Description > ------- > > So that stats collection can happen for multiple partitions through one > statement. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 8ae1c73 > ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java 47a6871 > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java > 1270520 > ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java a4ba4bd > ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java b75f78c > ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsDesc.java 86e6877 > ql/src/test/queries/clientnegative/columnstats_partlvl_dp.q b4887c4 > ql/src/test/queries/clientnegative/columnstats_partlvl_incorrect_num_keys.q > 2f8e927 > ql/src/test/queries/clientpositive/columnstats_partlvl_dp.q PRE-CREATION > ql/src/test/queries/clientpositive/columnstats_partlvl_incorrect_num_keys.q > PRE-CREATION > ql/src/test/results/clientnegative/columnstats_partlvl_invalid_values.q.out > d48d8cb > ql/src/test/results/clientpositive/columnstats_partlvl.q.out a4c4677 > ql/src/test/results/clientpositive/columnstats_partlvl_dp.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/columnstats_partlvl_incorrect_num_keys.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/22770/diff/ > > > Testing > ------- > > Moved -ve tests to +ve. > > > Thanks, > > Ashutosh Chauhan > >
