----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22033/#review45537 -----------------------------------------------------------
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DynamicFileRecordWriterContainer.java <https://reviews.apache.org/r/22033/#comment80380> Please make it clear in the comment that "dynamic" refers to dynamic partitions. hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DynamicFileRecordWriterContainer.java <https://reviews.apache.org/r/22033/#comment80381> Is this the result of automated formatting or something that you're doing by hand? hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/StaticFileRecordWriterContainer.java <https://reviews.apache.org/r/22033/#comment80382> Please make it clear in the comment that "static" refers to static partitions. Also, does it make sense to change the name to StaticPartitionFileRecordWriterContainer? Extremely verbose but it gets the point across and avoids confusion. - Carl Steinbach On May 29, 2014, 7:33 p.m., David Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22033/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 7:33 p.m.) > > > Review request for hive. > > > Bugs: HIVE-7094 > https://issues.apache.org/jira/browse/HIVE-7094 > > > Repository: hive-git > > > Description > ------- > > HIVE-7093: Separate static and dynamic partitioning implementations from > FileRecordWriterContainer. > > > Diffs > ----- > > > hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DynamicFileRecordWriterContainer.java > PRE-CREATION > > hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputFormatContainer.java > e9ca263abade20b7423ad98695807a60ab957ead > > hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileRecordWriterContainer.java > b55a05528d5a4eed114b5628697cf5a60f6c6cbc > > hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/StaticFileRecordWriterContainer.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/22033/diff/ > > > Testing > ------- > > > Thanks, > > David Chen > >
