> On June 11, 2014, 11:25 p.m., Jitendra Pandey wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ColAndCol.java, > > line 118 > > <https://reviews.apache.org/r/22478/diff/1/?file=607639#file607639line118> > > > > Please confirm hive semantics that > > NULL AND FALSE is FALSE and not NULL.
Looked at GenericUDFOPAnd. evaluate(), it will return FALSE if either one of the arguments is FALSE. So this is consistent with non-vectorized behavior. - Hari Sankar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22478/#review45438 ----------------------------------------------------------- On June 11, 2014, 9:23 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22478/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 9:23 p.m.) > > > Review request for hive, Gopal V and Jitendra Pandey. > > > Bugs: HIVE-7188 > https://issues.apache.org/jira/browse/HIVE-7188 > > > Repository: hive-git > > > Description > ------- > > ColAndCol.evaluate() is incorrectly implemented. Needed to rewrite the > evaluate(). Also added junit tests. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ColAndCol.java > cb2a952 > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorLogicalExpressions.java > 3df7c14 > > Diff: https://reviews.apache.org/r/22478/diff/ > > > Testing > ------- > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
