[ https://issues.apache.org/jira/browse/HIVE-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004838#comment-14004838 ]
Xuefu Zhang commented on HIVE-7048: ----------------------------------- The might be some misunderstanding. While CompositeKeyHBaseFactory was just recently introduced, HBaseSerDe.HBASE_COMPOSITE_KEY_CLASS is old. CompositeKeyHBaseFactory was to replace the old implementation around HBaseSerDe.HBASE_COMPOSITE_KEY_CLASS. The intention of extending this functionality is good, but the obvious difficulty of doing so w/o knowing much about the key would make me think twice. If we make CompositeKeyHBaseFactory abstract, user isn't able to use HBaseSerDe.HBASE_COMPOSITE_KEY_CLASS to specify a key class any more. > CompositeKeyHBaseFactory should not use FamilyFilter > ---------------------------------------------------- > > Key: HIVE-7048 > URL: https://issues.apache.org/jira/browse/HIVE-7048 > Project: Hive > Issue Type: Improvement > Components: HBase Handler > Reporter: Swarnim Kulkarni > Assignee: Swarnim Kulkarni > Priority: Blocker > Attachments: HIVE-7048.1.patch.txt > > > HIVE-6411 introduced a more generic way to provide composite key > implementations via custom factory implementations. However it seems like the > CompositeHBaseKeyFactory implementation uses a FamilyFilter for row key scans > which doesn't seem appropriate. This should be investigated further and if > possible replaced with a RowRangeScanFilter. -- This message was sent by Atlassian JIRA (v6.2#6252)