> On May 16, 2014, 11:28 p.m., Ashutosh Chauhan wrote: > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JIRAService.java, > > line 269 > > <https://reviews.apache.org/r/21589/diff/2/?file=583785#file583785line269> > > > > instead of hard-coding url, is it possible to pass this on?
Thanks Ashutosh for the review. Sorry for the confusion, the logsURL is taken from a properties file as in the rest of the code. This code in particular is apparently for testing , and not used in production. When it runs it will use these arguments to try to post to a random JIRA. That is what I used to try to verify the functionality. - Szehon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21589/#review43287 ----------------------------------------------------------- On May 16, 2014, 10:57 p.m., Szehon Ho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21589/ > ----------------------------------------------------------- > > (Updated May 16, 2014, 10:57 p.m.) > > > Review request for hive and Brock Noland. > > > Bugs: HIVE-7080 > https://issues.apache.org/jira/browse/HIVE-7080 > > > Repository: hive-git > > > Description > ------- > > Adding a 'test logs' section to the HiveQA's JIRA comment. This is done by > yet another build-configuration property "logsURL". > > > Diffs > ----- > > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JIRAService.java > a17295a > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java > 5c552e7 > > Diff: https://reviews.apache.org/r/21589/diff/ > > > Testing > ------- > > Ran the JIRAService as JavaApplication to manually test it. > > > Thanks, > > Szehon Ho > >
