[
https://issues.apache.org/jira/browse/HIVE-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981567#comment-13981567
]
Xuefu Zhang commented on HIVE-6469:
-----------------------------------
[~jhsenjaliya] Thanks for the patch. It looks good to me. Minor nit: Hive code
style expects space between ){ in the following if/else block.
{code}
+ if (skipTrash){
+ LOG.info("Not moving"+ f +" to trash due to configuration " +
+ HiveConf.ConfVars.HIVE_WAREHOUSE_DATA_SKIPTRASH + " is set to
true.");
+ }else if (hadoopShim.moveToAppropriateTrash(fs, f, conf)) {
{code}
Would you mind fixing the format?
> skipTrash option in hive command line
> -------------------------------------
>
> Key: HIVE-6469
> URL: https://issues.apache.org/jira/browse/HIVE-6469
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Affects Versions: 0.12.0
> Reporter: Jayesh
> Fix For: 0.12.1
>
> Attachments: HIVE-6469.1.patch, HIVE-6469.patch
>
>
> hive drop table command deletes the data from HDFS warehouse and puts it into
> Trash.
> Currently there is no way to provide flag to tell warehouse to skip trash
> while deleting table data.
> This ticket is to add skipTrash feature in hive command-line, that looks as
> following.
> hive -e "drop table skipTrash testTable"
> This would be good feature to add, so that user can specify when not to put
> data into trash directory and thus not to fill hdfs space instead of relying
> on trash interval and policy configuration to take care of disk filling issue.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
