[ https://issues.apache.org/jira/browse/HIVE-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974949#comment-13974949 ]
Hive QA commented on HIVE-4576: ------------------------------- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12640925/HIVE-4576.2.patch {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 5407 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_auto_sortmerge_join_16 org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucketizedhiveinputformat org.apache.hadoop.hive.ql.security.TestMetastoreAuthorizationProvider.testSimplePrivileges {noformat} Test results: ec2-174-129-184-35.compute-1.amazonaws.com/precommit-hive/11/testReport Console output: ec2-174-129-184-35.compute-1.amazonaws.com/precommit-hive/11/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12640925 > templeton.hive.properties does not allow values with commas > ----------------------------------------------------------- > > Key: HIVE-4576 > URL: https://issues.apache.org/jira/browse/HIVE-4576 > Project: Hive > Issue Type: Bug > Components: WebHCat > Affects Versions: 0.5.0 > Reporter: Vitaliy Fuks > Assignee: Eugene Koifman > Priority: Minor > Attachments: HIVE-4576.2.patch, HIVE-4576.patch > > > templeton.hive.properties accepts a comma-separated list of key=value > property pairs that will be passed to Hive. > However, this makes it impossible to use any "value" that itself has a comma > in it. > For example: > {code:xml}<property> > <name>templeton.hive.properties</name> > > <value>hive.metastore.sasl.enabled=false,hive.metastore.uris=thrift://foo1.example.com:9083,foo2.example.com:9083</value> > </property>{code} > {noformat}templeton: starting [/usr/bin/hive, --service, cli, --hiveconf, > hive.metastore.sasl.enabled=false, --hiveconf, > hive.metastore.uris=thrift://foo1.example.com:9083, --hiveconf, > foo2.example.com:9083 etc..{noformat} > because the value is parsed using standard > org.apache.hadoop.conf.Configuration.getStrings() call which simply splits on > commas from here: > {code:java}for (String prop : > appConf.getStrings(AppConfig.HIVE_PROPS_NAME)){code} > This is problematic for any hive property that itself has multiple values, > such as hive.metastore.uris above or hive.aux.jars.path. > There should be some way to "escape" commas or a different delimiter should > be used. -- This message was sent by Atlassian JIRA (v6.2#6252)