[ https://issues.apache.org/jira/browse/HIVE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963316#comment-13963316 ]
Szehon Ho commented on HIVE-6853: --------------------------------- Thanks for the fix, only one minor comment, is it needed to make a StringBuilder when there is only one string to return? Also can you upload the patch in right name-format? The precommit test takes patches in the form HIVE-XXXX.patch or HIVE-XXXX.n.patch only. > show create table for hbase tables should exclude LOCATION > ----------------------------------------------------------- > > Key: HIVE-6853 > URL: https://issues.apache.org/jira/browse/HIVE-6853 > Project: Hive > Issue Type: Bug > Components: StorageHandler > Affects Versions: 0.10.0 > Reporter: Miklos Christine > Attachments: HIVE-6853-0.patch > > > If you create a table on top of hbase in hive and issue a "show create table > <hbase_table>", it gives a bad DDL. It should not show LOCATION: > > > [hive]$ cat /tmp/test_create.sql > CREATE EXTERNAL TABLE nba_twitter.hbase2( > key string COMMENT 'from deserializer', > name string COMMENT 'from deserializer', > pdt string COMMENT 'from deserializer', > service string COMMENT 'from deserializer', > term string COMMENT 'from deserializer', > update1 string COMMENT 'from deserializer') > ROW FORMAT SERDE > 'org.apache.hadoop.hive.hbase.HBaseSerDe' > STORED BY > 'org.apache.hadoop.hive.hbase.HBaseStorageHandler' > WITH SERDEPROPERTIES ( > 'serialization.format'='1', > 'hbase.columns.mapping'=':key,srv:name,srv:pdt,srv:service,srv:term,srv:update') > LOCATION > 'hdfs://nameservice1/user/hive/warehouse/nba_twitter.db/hbase' > TBLPROPERTIES ( > 'hbase.table.name'='NBATwitter', > 'transient_lastDdlTime'='1386172188') > Trying to create a table using the above fails: > [hive]$ hive -f /tmp/test_create.sql > cli "-f /tmp/test_create.sql" > Logging initialized using configuration in > jar:file:/opt/cloudera/parcels/CDH-4.4.0-1.cdh4.4.0.p0.39/lib/hive/lib/hive-common-0.10.0-cdh4.4.0.jar!/hive-log4j.properties > FAILED: Error in metadata: MetaException(message:LOCATION may not be > specified for HBase.) > FAILED: Execution Error, return code 1 from > org.apache.hadoop.hive.ql.exec.DDLTask > However, if I remove the LOCATION, then the DDL is valid. -- This message was sent by Atlassian JIRA (v6.2#6252)