----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19889/ -----------------------------------------------------------
Review request for hive and Thejas Nair. Bugs: HIVE-6796 https://issues.apache.org/jira/browse/HIVE-6796 Repository: hive-git Description ------- Create/drop roles is case-sensitive whereas 'set role' is case insensitive Diffs ----- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 27077b4 ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java f4dd97b ql/src/java/org/apache/hadoop/hive/ql/plan/GrantRevokeRoleDDL.java d8488a7 ql/src/java/org/apache/hadoop/hive/ql/plan/PrincipalDesc.java 7dc0ded ql/src/java/org/apache/hadoop/hive/ql/plan/RoleDDLDesc.java b4da3d1 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrincipal.java 62b8994 ql/src/test/results/clientnegative/authorization_drop_db_cascade.q.out eda2146 ql/src/test/results/clientnegative/authorization_drop_db_empty.q.out 27a6822 ql/src/test/results/clientnegative/authorization_drop_role_no_admin.q.out c03876d ql/src/test/results/clientnegative/authorization_fail_7.q.out ffff69d ql/src/test/results/clientnegative/authorization_priv_current_role_neg.q.out 7f983ba ql/src/test/results/clientnegative/authorization_public_create.q.out bccdc53 ql/src/test/results/clientnegative/authorization_public_drop.q.out 14f6b3a ql/src/test/results/clientnegative/authorization_role_grant.q.out 0f88444 ql/src/test/results/clientnegative/authorization_rolehierarchy_privs.q.out 7268370 ql/src/test/results/clientnegative/authorize_grant_public.q.out dae4331 ql/src/test/results/clientnegative/authorize_revoke_public.q.out cff88ca ql/src/test/results/clientpositive/authorization_1.q.out 1c52151 ql/src/test/results/clientpositive/authorization_1_sql_std.q.out 3e39801 ql/src/test/results/clientpositive/authorization_5.q.out 3353adf ql/src/test/results/clientpositive/authorization_9.q.out 3ec988c ql/src/test/results/clientpositive/authorization_admin_almighty1.q.out df0d5c4 ql/src/test/results/clientpositive/authorization_role_grant1.q.out 305dd9d ql/src/test/results/clientpositive/authorization_role_grant2.q.out f294311 ql/src/test/results/clientpositive/authorization_set_show_current_role.q.out d5fbc48 ql/src/test/results/clientpositive/authorization_view_sqlstd.q.out b431c35 Diff: https://reviews.apache.org/r/19889/diff/ Testing ------- Updated existing test cases. Thanks, Ashutosh Chauhan