----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19718/#review38958 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapper.java <https://reviews.apache.org/r/19718/#comment71328> please add a comment to explain why we use the sum of all the counts here to determine the array size. ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapper.java <https://reviews.apache.org/r/19718/#comment71329> Consider for readability/encapsulation having a function to compute offset, e.g. isNull[decimalOffset(index)] = false; Please add a comment to explain offset logic. Does addition of decimal affect any other offsets? I guess not. ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java <https://reviews.apache.org/r/19718/#comment71330> Timestamp is supposed to be represented as a long (# of nanos since epoch). So whey is this using a FilterStringColumnBetween? ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java <https://reviews.apache.org/r/19718/#comment71331> Again, why string and not long "not between" operator? - Eric Hanson On March 28, 2014, 9:56 p.m., Jitendra Pandey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19718/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 9:56 p.m.) > > > Review request for hive and Eric Hanson. > > > Bugs: HIVE-6752 > https://issues.apache.org/jira/browse/HIVE-6752 > > > Repository: hive-git > > > Description > ------- > > Vectorized Between and IN expressions don't work with decimal, date types. > > > Diffs > ----- > > ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 44b0c59 > ql/src/gen/vectorization/ExpressionTemplates/FilterDecimalColumnBetween.txt > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapper.java > 2229079 > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java > 96e74a9 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDateToString.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DecimalColumnInList.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterDecimalColumnInList.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IDecimalInExpr.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java > c2240c0 > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java > 5ebab70 > ql/src/test/queries/clientpositive/vector_between_in.q PRE-CREATION > ql/src/test/results/clientpositive/vector_between_in.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/19718/diff/ > > > Testing > ------- > > > Thanks, > > Jitendra Pandey > >
