----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19623/#review38688 -----------------------------------------------------------
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniMr.java <https://reviews.apache.org/r/19623/#comment70985> This comment is not related to this patch. But I would expect the right behavior for 'describe function ' on a function that does not exist to result in a query failure. ie a SQLException . itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniMr.java <https://reviews.apache.org/r/19623/#comment70984> lets remove this commented line. - Thejas Nair On March 25, 2014, 6:02 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19623/ > ----------------------------------------------------------- > > (Updated March 25, 2014, 6:02 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-6744 > https://issues.apache.org/jira/browse/HIVE-6744 > > > Repository: hive-git > > > Description > ------- > > Make sure DB name is lowercased when doing lookups for permanent UDFs. > > > Diffs > ----- > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniMr.java > 885803b > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java > d76750c > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java b7da95e > > Diff: https://reviews.apache.org/r/19623/diff/ > > > Testing > ------- > > test added > > > Thanks, > > Jason Dere > >
