----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19525/ -----------------------------------------------------------
Review request for hive. Bugs: HIVE-6510 https://issues.apache.org/jira/browse/HIVE-6510 Repository: hive-git Description ------- HIVE-6327, HIVE-6246 and HIVE-6385 touched a lot of the math based UDFs. There are some code inconsistencies and warnings left. This cleans up all the problems I could find. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/udf/UDFAcos.java 18c79a7 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFAsin.java cfd5d38 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFAtan.java 641bba2 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFCos.java bfa95ee ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDegrees.java bc5e1e2 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFExp.java cf6f53e ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLn.java eb5f646 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog.java 7a4d8a7 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog10.java 00dc319 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog2.java 9202258 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMath.java c1981af ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRadians.java fd1f0e3 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSign.java 6e4bee0 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSin.java 8f757f2 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSqrt.java 17094c9 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFTan.java c286619 Diff: https://reviews.apache.org/r/19525/diff/ Testing ------- Thanks, Lars Francke