> On March 15, 2014, 12:19 a.m., Xuefu Zhang wrote: > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java, > > line 275 > > <https://reviews.apache.org/r/19247/diff/1/?file=520087#file520087line275> > > > > Since the problem comes from upper layer, I'm wondering if this should > > be fixed there instead. > > Brock Noland wrote: > Yeah I think ideally we should support this case. However, it might make > sense to commit a temporary fix and resolve the larger issue in a follow-on > jira. > > Nick, how impactful is this to the hbase use case? > > Ashutosh Chauhan wrote: > I agree. Proper fix is in higher layer. However, to get this in for 0.13 > we can have this quick fix and track the proper fix in another jira. > w.r.t impact I don't see this resulting in reduced functionality or > performance in any way. > Nick, can you re-upload the patch so that Hive QA picks it up. > > nick dimiduk wrote: > I opened HIVE-6678 for fixing the problem at a higher level. > > nick dimiduk wrote: > @brock I've tested this patch with the query format described in the bug > -- it is fixed. I'm depending on the buildbot to run a more through test > suite run. I question the unit tests' validity considering there's no > optimizations enabled in general, which is why this issue wasn't caught back > when the optimization was implemented in the first place.
@brock I've tested this patch with the query format described in the bug -- it if fixed. I'm depending on the buildbot to run a more through test suite run. I question the unit tests' validity considering there's no optimizations enabled in general, which is why this issue wasn't caught back when the optimization was implemented in the first place. > On March 15, 2014, 12:19 a.m., Xuefu Zhang wrote: > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java, > > line 275 > > <https://reviews.apache.org/r/19247/diff/1/?file=520087#file520087line275> > > > > Since the problem comes from upper layer, I'm wondering if this should > > be fixed there instead. > > Brock Noland wrote: > Yeah I think ideally we should support this case. However, it might make > sense to commit a temporary fix and resolve the larger issue in a follow-on > jira. > > Nick, how impactful is this to the hbase use case? > > Ashutosh Chauhan wrote: > I agree. Proper fix is in higher layer. However, to get this in for 0.13 > we can have this quick fix and track the proper fix in another jira. > w.r.t impact I don't see this resulting in reduced functionality or > performance in any way. > Nick, can you re-upload the patch so that Hive QA picks it up. > > nick dimiduk wrote: > I opened HIVE-6678 for fixing the problem at a higher level. > > nick dimiduk wrote: > @brock I've tested this patch with the query format described in the bug > -- it if fixed. I'm depending on the buildbot to run a more through test > suite run. I question the unit tests' validity considering there's no > optimizations enabled in general, which is why this issue wasn't caught back > when the optimization was implemented in the first place. @brock I've tested this patch with the query format described in the bug -- it is fixed. I'm depending on the buildbot to run a more through test suite run. I question the unit tests' validity considering there's no optimizations enabled in general, which is why this issue wasn't caught back when the optimization was implemented in the first place. - nick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19247/#review37298 ----------------------------------------------------------- On March 20, 2014, 7:17 p.m., nick dimiduk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19247/ > ----------------------------------------------------------- > > (Updated March 20, 2014, 7:17 p.m.) > > > Review request for hive. > > > Bugs: HIVE-6650 > https://issues.apache.org/jira/browse/HIVE-6650 > > > Repository: hive-git > > > Description > ------- > > With the above enabled, where clauses including non-rowkey columns cannot be > used with the HBaseStorageHandler. See ticket for full details. > > > Diffs > ----- > > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java > 704fcb9 > hbase-handler/src/test/queries/positive/hbase_pushdown.q 69a4536 > hbase-handler/src/test/results/positive/hbase_pushdown.q.out ee9e20c > > Diff: https://reviews.apache.org/r/19247/diff/ > > > Testing > ------- > > Included patch allows said query to run. Waiting on build bot for test suite. > > > Thanks, > > nick dimiduk > >
