----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19395/#review37915 -----------------------------------------------------------
Ship it! Thanks for adding the test! The patch look fine to me. Just wondering if the test could be a big flaky due to timings. We should keep an eye if it fails intermittently. It might help to set static flags to throttle the UDF execution. - Prasad Mujumdar On March 20, 2014, 7:42 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19395/ > ----------------------------------------------------------- > > (Updated March 20, 2014, 7:42 a.m.) > > > Review request for hive, Jason Dere, Prasad Mujumdar, and Thejas Nair. > > > Bugs: HIVE-6472 > https://issues.apache.org/jira/browse/HIVE-6472 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-6472 > > > Diffs > ----- > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > c91df83 > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 01e6ea7 > service/src/java/org/apache/hive/service/cli/OperationState.java a023908 > > service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java > 89f2ae9 > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 3f36e2d > > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java > 345617c > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > ace791a > > Diff: https://reviews.apache.org/r/19395/diff/ > > > Testing > ------- > > Added a new test to TestJdbcDriver2 and did testing with standalone jdbc > program. > > > Thanks, > > Vaibhav Gumashta > >
