----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19265/#review37502 -----------------------------------------------------------
hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject.java <https://reviews.apache.org/r/19265/#comment69048> Yes, but parseColumnsMapping(String, boolean) is removed from HiveSerde and mainly needed here. Thus, I think it makes sense to move that to this test class. It just makes the production code cleaner. - Xuefu Zhang On March 16, 2014, 5:33 p.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19265/ > ----------------------------------------------------------- > > (Updated March 16, 2014, 5:33 p.m.) > > > Review request for hive. > > > Bugs: HIVE-6677 > https://issues.apache.org/jira/browse/HIVE-6677 > > > Repository: hive-git > > > Description > ------- > > Pure refactoring. For the purpose of what is described in the JIRA. Mostly, > separating key serialization from column serialization. When possible, static > methods are used. Some code cleanup is made. All serde properties, including > those dedicated for HBaseSerde, is captured in class HBaseSerDeParameters. > > > Diffs > ----- > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java 2cd65cb > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDeParameters.java > PRE-CREATION > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java > 29e5da5 > > hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject.java > db69ae5 > > Diff: https://reviews.apache.org/r/19265/diff/ > > > Testing > ------- > > No new tests. Test suite passed successfully. > > > Thanks, > > Xuefu Zhang > >
