----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19212/ -----------------------------------------------------------
(Updated March 14, 2014, 9:23 p.m.) Review request for hive. Changes ------- Updating patch based on feedback from Mohammad Islam Bugs: HIVE-6645 https://issues.apache.org/jira/browse/HIVE-6645 Repository: hive-git Description ------- - fix null inputs - allow char/varchar params - tests Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java c31174a ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToUnixTimeStamp.java dc259c6 ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDate.java 384ce4e ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFToUnixTimestamp.java PRE-CREATION Diff: https://reviews.apache.org/r/19212/diff/ Testing ------- Thanks, Jason Dere