----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18992/#review37089 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java <https://reviews.apache.org/r/18992/#comment68385> Maybe create a method to remove the running job from the list, as opposed to having callers manipulate this list directly. Looks like there are a few places in the code where this list is access in this way. ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java <https://reviews.apache.org/r/18992/#comment68386> Is this kill command still valid, or is it only the HTTP method which no longer works to kill jobs? ql/src/java/org/apache/hadoop/hive/ql/plan/ReducerTimeStatsPerJob.java <https://reviews.apache.org/r/18992/#comment68389> why is this removed? - Jason Dere On March 12, 2014, 4:49 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18992/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 4:49 p.m.) > > > Review request for hive. > > > Bugs: HIVE-6609 > https://issues.apache.org/jira/browse/HIVE-6609 > > > Repository: hive-git > > > Description > ------- > > Switched to java api to kill jobs instead of url based job killing. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 288da8e > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java > a4585de > ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/BlockMergeTask.java > 5a6899c > ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanTask.java > 4b58d92 > > ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateTask.java > 21b537c > ql/src/java/org/apache/hadoop/hive/ql/plan/ReducerTimeStatsPerJob.java > 40c27e3 > > Diff: https://reviews.apache.org/r/18992/diff/ > > > Testing > ------- > > Manually tested for both Hadoop-1 & Hadoop-2. Working as expected. > > > Thanks, > > Ashutosh Chauhan > >
