----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18808/#review36558 -----------------------------------------------------------
Ship it! looks good to me! common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java <https://reviews.apache.org/r/18808/#comment67561> Can you open a bug for scaleDownTenDestructive, based on what you found? You can make it low priority since it is not getting called in the current code paths. But it will be good to have a record of it. - Eric Hanson On March 7, 2014, 4:39 a.m., Jitendra Pandey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18808/ > ----------------------------------------------------------- > > (Updated March 7, 2014, 4:39 a.m.) > > > Review request for hive and Eric Hanson. > > > Bugs: HIVE-6511 > https://issues.apache.org/jira/browse/HIVE-6511 > > > Repository: hive-git > > > Description > ------- > > Casting from decimal to tinyint,smallint, int and bigint generates different > result when vectorization is on. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java a5d7399 > common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java > 426c03d > > Diff: https://reviews.apache.org/r/18808/diff/ > > > Testing > ------- > > > Thanks, > > Jitendra Pandey > >
