[
https://issues.apache.org/jira/browse/HIVE-6332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13922159#comment-13922159
]
Lefty Leverenz commented on HIVE-6332:
--------------------------------------
Looks good overall. Of course I have some editorial nits, but they shouldn't
clutter up this jira. One typo you could fix now:
hcat.dynamic.partitioning.custom.patttern (triple t).
An introduction would be helpful, mentioning the HCatConstants.java file and
explaining basic usage.
Why are cache parameters "hcatalog.hive.xxx" while all other parameters are
"hcat.xxx"? (I'm asking about hcat vs. hcatalog, not the hive part.)
This sentence in the first section confuses me: "An override to specify where
HCatStorer will write to, defined from pig jobs, either directly by user, or by
using org.apache.hive.hcatalog.pig.HCatStorerWrapper." Does it mean that Pig
jobs specify hcat.pig.storer.external.location? Could you give examples of
specifying by user and by HCatStorerWrapper?
In the Data Promotion section, this sentence seems a bit off: "On the write
side, it is expected that the user pass in valid HCatRecords with data
correctly." Does that mean with data correctly typed for Hive?
That's it for my first pass. I'll take another look later.
> HCatConstants Documentation needed
> ----------------------------------
>
> Key: HIVE-6332
> URL: https://issues.apache.org/jira/browse/HIVE-6332
> Project: Hive
> Issue Type: Task
> Reporter: Sushanth Sowmyan
> Assignee: Sushanth Sowmyan
>
> HCatConstants documentation is near non-existent, being defined only as
> comments in code for the various parameters. Given that a lot of api winds up
> being implemented as knobs that can be tweaked here, we should have a public
> facing doc for this.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
