[ https://issues.apache.org/jira/browse/HIVE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921381#comment-13921381 ]
Sushanth Sowmyan commented on HIVE-6507: ---------------------------------------- Noting that 2 of the test failures reported are due to the upgrade to 0.14, and one is disconnected from this issue. Also, the new patch does not change behaviour from the previous patch except for adding back in the string constants with deprecation notices, and thus, should not change test behaviour. > OrcFile table property names are specified as strings > ----------------------------------------------------- > > Key: HIVE-6507 > URL: https://issues.apache.org/jira/browse/HIVE-6507 > Project: Hive > Issue Type: Bug > Components: HCatalog, Serializers/Deserializers > Affects Versions: 0.13.0 > Reporter: Sushanth Sowmyan > Assignee: Sushanth Sowmyan > Attachments: HIVE-6507.2.patch, HIVE-6507.patch > > > In HIVE-5504, we had to do some special casing in HCatalog to add a > particular set of orc table properties from table properties to job > properties. > In doing so, it's obvious that that is a bit cumbersome, and ideally, the > list of all orc file table properties should really be an enum, rather than > individual loosely tied constant strings. If we were to clean this up, we can > clean up other code that references this to reference the entire enum, and > avoid future errors when new table properties are introduced, but other > referencing code is not updated. -- This message was sent by Atlassian JIRA (v6.2#6252)