----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18464/#review35730 -----------------------------------------------------------
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java <https://reviews.apache.org/r/18464/#comment66451> I think, instead of having to do identityContext equals "fromKerberosSubject", we can just use assumeSubject equals true/false, keeping the default to false. service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java <https://reviews.apache.org/r/18464/#comment66452> Can you push this to HadoopThriftAuthBridge.Client#createClientTransport just like the way the else portion does instead of the createSubjectAssumedTransport method? From within the method you can return the TSubjectAssumingTransport. - Vaibhav Gumashta On Feb. 25, 2014, 2:50 p.m., Kevin Minder wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18464/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2014, 2:50 p.m.) > > > Review request for hive, Kevin Minder and Vaibhav Gumashta. > > > Bugs: HIVE-6486 > https://issues.apache.org/jira/browse/HIVE-6486 > > > Repository: hive-git > > > Description > ------- > > Support secure Subject.doAs() in HiveServer2 JDBC client > > > Diffs > ----- > > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 17b4d39 > service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java > 379dafb > > service/src/java/org/apache/hive/service/auth/TSubjectAssumingTransport.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/18464/diff/ > > > Testing > ------- > > Manual testing > > > Thanks, > > Kevin Minder > >
