-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18065/#review35637
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
<https://reviews.apache.org/r/18065/#comment66268>

    Though its not super clear from 
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DML it seems to 
imply that source can be dir. Can you test the current behavior? ie whether 
loading from local dir is allowed or not currently. If it is allowed, we need 
to mimic that behavior here.



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
<https://reviews.apache.org/r/18065/#comment66267>

    Should this be srcs = srcFs.globStatus(srcf) instead ?


- Ashutosh Chauhan


On Feb. 26, 2014, 8:20 a.m., Mohammad Islam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18065/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 8:20 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-6024
>     https://issues.apache.org/jira/browse/HIVE-6024
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Excerpt from the JIRA:
> "Load data command creates an additional copy task only when its loading from 
> local It doesn't create this additional copy task while loading from DFS 
> though."
> 
> 
> Diffs
> -----
> 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
>  8beef09 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java ed7787d 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 05a2da7 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 8318be1 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 
> 59aeb96 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/MoveWork.java 407450e 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 5991aae 
> 
> Diff: https://reviews.apache.org/r/18065/diff/
> 
> 
> Testing
> -------
> 
> Ran some existing q tests with "LOAD DATA LOCAL INPATH".
> 
> 
> Thanks,
> 
> Mohammad Islam
> 
>

Reply via email to