----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18208/#review35224 -----------------------------------------------------------
service/src/java/org/apache/hive/service/auth/HttpAuthHelper.java <https://reviews.apache.org/r/18208/#comment65680> I assume these classes are not actually required for the LDAP changes. Lets include only the LDAP relevant changes to this jira. service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java <https://reviews.apache.org/r/18208/#comment65676> It will be better to use AuthenticationProviderFactory.getAuthenticationProvider here. That way custom auth (and PAM) support also gets automatically added. service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java <https://reviews.apache.org/r/18208/#comment65678> doLdapAuth returning username is not intuitive. I think it is better to pass username and password to the function. service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java <https://reviews.apache.org/r/18208/#comment65677> This is not really an error in terms of the servers operation, ie does not affect the uptime of the server or other server problems. I think we should just use info level logs if client failed to authorize correctly. The client is the one that should get error messages for this. service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java <https://reviews.apache.org/r/18208/#comment65679> I think we should just call this function with username and password as arguments. - Thejas Nair On Feb. 18, 2014, 10:29 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18208/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 10:29 a.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-6350 > https://issues.apache.org/jira/browse/HIVE-6350 > > > Repository: hive-git > > > Description > ------- > > Support LDAP authentication for HiveServer2 in http mode > > > Diffs > ----- > > service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java d8ba3aa > service/src/java/org/apache/hive/service/auth/HttpAuthHelper.java > PRE-CREATION > > service/src/java/org/apache/hive/service/auth/HttpAuthenticationException.java > PRE-CREATION > service/src/java/org/apache/hive/service/auth/HttpCLIServiceProcessor.java > PRE-CREATION > > service/src/java/org/apache/hive/service/auth/HttpCLIServiceUGIProcessor.java > PRE-CREATION > > service/src/java/org/apache/hive/service/auth/LdapAuthenticationProviderImpl.java > 5342214 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > bfe0e7b > > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java > a6ff6ce > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java > e77f043 > shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java > 9e9a60d > > Diff: https://reviews.apache.org/r/18208/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
