----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18185/#review35196 -----------------------------------------------------------
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java <https://reviews.apache.org/r/18185/#comment65649> I believe using the hadoop classes here will require hadoop-common*jar also to be copied to jdbc client machine. We should move the use of these classes to a different class, that would get used only when jdbc+kerberos is used. jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java <https://reviews.apache.org/r/18185/#comment65650> the flow will be clearer with an else-if instead of if. jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java <https://reviews.apache.org/r/18185/#comment65652> If useSsl == true, I think we should throw an exception (with http-kerberos) with appropriate error message. Otherwise people would have a false sense of security of ssl being used. jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java <https://reviews.apache.org/r/18185/#comment65653> can you get rid of these trailing white spaces - Thejas Nair On Feb. 17, 2014, 9:24 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18185/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2014, 9:24 a.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-4764 > https://issues.apache.org/jira/browse/HIVE-4764 > > > Repository: hive-git > > > Description > ------- > > Support Kerberos HTTP authentication for HiveServer2 running in http mode > > > Diffs > ----- > > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 13fc19b > jdbc/src/java/org/apache/hive/jdbc/HttpBasicAuthInterceptor.java 66eba1b > jdbc/src/java/org/apache/hive/jdbc/HttpKerberosRequestInterceptor.java > PRE-CREATION > service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java d8ba3aa > service/src/java/org/apache/hive/service/auth/HttpAuthHelper.java > PRE-CREATION > > service/src/java/org/apache/hive/service/auth/HttpAuthenticationException.java > PRE-CREATION > service/src/java/org/apache/hive/service/cli/CLIService.java 56b357a > > service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java > 6fbc847 > > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java > a6ff6ce > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java > e77f043 > > Diff: https://reviews.apache.org/r/18185/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
