> On Feb. 21, 2014, 2:43 a.m., Gunther Hagleitner wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/LazyFlatRowContainer.java, > > line 93 > > <https://reviews.apache.org/r/18061/diff/4/?file=497178#file497178line93> > > > > Is there a reason why you sometimes use assert sometimes AssertionError > > (on the same condition)?
those that throw I want to apply in production :) - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18061/#review35110 ----------------------------------------------------------- On Feb. 18, 2014, 10:25 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18061/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 10:25 p.m.) > > > Review request for hive and Gunther Hagleitner. > > > Repository: hive-git > > > Description > ------- > > See JIRA > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a182cd7 > ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java aacf200 > ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java > 24f1229 > ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java 2981a3b > ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java c0f4cd7 > ql/src/java/org/apache/hadoop/hive/ql/exec/PTFPartition.java 01d31a7 > ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 7a7dc88 > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/AbstractRowContainer.java > 778d016 > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/LazyFlatRowContainer.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinEagerRowContainer.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinRowContainer.java > b7f66fe > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinTableContainer.java > 9ce0ae6 > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinTableContainerSerDe.java > 83ba0f0 > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/PTFRowContainer.java > 9b2babc > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/RowContainer.java > 3b0bc2a > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HashTableLoader.java 47f9d21 > > ql/src/test/org/apache/hadoop/hive/ql/exec/persistence/TestMapJoinEqualityTableContainer.java > c541ad2 > > ql/src/test/org/apache/hadoop/hive/ql/exec/persistence/TestMapJoinRowContainer.java > 21de0f5 > > ql/src/test/org/apache/hadoop/hive/ql/exec/persistence/TestMapJoinTableContainer.java > 61c5741 > > ql/src/test/org/apache/hadoop/hive/ql/exec/persistence/TestPTFRowContainer.java > 900a574 > ql/src/test/org/apache/hadoop/hive/ql/exec/persistence/Utilities.java > 2cb1ac3 > ql/src/test/queries/clientpositive/mapjoin_mapjoin.q 3f87db2 > ql/src/test/results/clientpositive/tez/mapjoin_mapjoin.q.out 90d158b > > serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java > 0324453 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java > 64e651c > > Diff: https://reviews.apache.org/r/18061/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
