----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18200/#review35067 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/HiveAuxClasspathBuilder.java <https://reviews.apache.org/r/18200/#comment65457> This also seems to be a static class. Again, a minor issue. ql/src/java/org/apache/hadoop/hive/ql/exec/mr/JarCache.java <https://reviews.apache.org/r/18200/#comment65458> I agree this is a minor issue, but I don't see why there is a need of mocking it ever. - Xuefu Zhang On Feb. 19, 2014, 8:35 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18200/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 8:35 p.m.) > > > Review request for hive. > > > Bugs: HIVE-860 > https://issues.apache.org/jira/browse/HIVE-860 > > > Repository: hive-git > > > Description > ------- > > Caches auxiliary jars and remote runtime jars in /user/$user/.hiveJars by > their sha1 hash. This results in: > > 1) faster queries > 2) less distributed cache churn > 3) a smaller/cleaner hive-exec jar > > > Diffs > ----- > > bin/hive 3bd949f > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a182cd7 > conf/hive-default.xml.template 0d08aa2 > packaging/src/main/assembly/bin.xml a97ef7d > ql/pom.xml 53d0b9e > ql/src/java/org/apache/hadoop/hive/ql/exec/HiveAuxClasspathBuilder.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 288da8e > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/JarCache.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 326654f > shims/aggregator/pom.xml 7aa8c4c > > Diff: https://reviews.apache.org/r/18200/diff/ > > > Testing > ------- > > Tested manually on a cluster. > > > Thanks, > > Brock Noland > >
