----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18250/#review34941 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java <https://reviews.apache.org/r/18250/#comment65337> missing space before "granted" ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java <https://reviews.apache.org/r/18250/#comment65342> I think it will be better to replace "or " with " Otherwise, " . ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java <https://reviews.apache.org/r/18250/#comment65333> can you call this one currentRoles ? Otherwise the variable names are too similar making it little hard to read. ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java <https://reviews.apache.org/r/18250/#comment65334> currentRole as variable name instead of role? ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java <https://reviews.apache.org/r/18250/#comment65335> indentation ql/src/test/queries/clientnegative/authorization_role_grant.q <https://reviews.apache.org/r/18250/#comment65341> Can you also state in the comment that this test is verifying that user needs to have role being granted in current role. - Thejas Nair On Feb. 19, 2014, 9:51 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18250/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 9:51 p.m.) > > > Review request for hive. > > > Bugs: HIVE-6433 > https://issues.apache.org/jira/browse/HIVE-6433 > > > Repository: hive-git > > > Description > ------- > > SQL std auth - allow grant/revoke roles if user has ADMIN OPTION > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java > c1afaee > ql/src/test/queries/clientnegative/authorization_role_grant.q PRE-CREATION > ql/src/test/queries/clientpositive/authorization_role_grant2.q PRE-CREATION > ql/src/test/results/clientnegative/authorization_role_grant.q.out > PRE-CREATION > ql/src/test/results/clientnegative/authorization_set_role_neg2.q.out > eec684d > ql/src/test/results/clientpositive/authorization_role_grant2.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/18250/diff/ > > > Testing > ------- > > Added new test > > > Thanks, > > Ashutosh Chauhan > >
