-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17494/#review34835
-----------------------------------------------------------

Ship it!


Ship It!

- Ashutosh Chauhan


On Feb. 19, 2014, 2:22 a.m., Jason Dere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17494/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 2:22 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6330
>     https://issues.apache.org/jira/browse/HIVE-6330
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Metastore changes, CREATE FUNCTION support (without TEMPORARY keyword), 
> lookup of functions in the metastore. The UDF class needs to be resolvable by 
> the class loader in Hive.
> Generated thrift changes not included in diff.
> 
> 
> Diffs
> -----
> 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
>  2552414 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java ca43932 
>   metastore/if/hive_metastore.thrift 347aad9 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
> bec21cf 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
> 6dce0aa 
>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
> 6bf1bf1 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
> 16e189a 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 0a76cee 
>   metastore/src/model/org/apache/hadoop/hive/metastore/model/MFunction.java 
> PRE-CREATION 
>   metastore/src/model/package.jdo e6aebdd 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
>  c53a412 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
>  ed3d7ee 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 92fee9b 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 988b389 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionUtils.java 7fd4859 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 0b7c128 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java 
> cc12f30 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 4d58f96 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/MacroSemanticAnalyzer.java 
> 36f8f71 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateFunctionDesc.java 051095a 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/DropFunctionDesc.java 8a78f5b 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java 
> 0d02f6e 
>   ql/src/test/queries/clientnegative/create_function_nonexistent_class.q 
> PRE-CREATION 
>   ql/src/test/queries/clientnegative/create_function_nonexistent_db.q 
> PRE-CREATION 
>   ql/src/test/queries/clientnegative/create_function_nonudf_class.q 
> PRE-CREATION 
>   ql/src/test/queries/clientnegative/drop_func_nonexistent.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/create_func1.q PRE-CREATION 
>   ql/src/test/results/clientnegative/create_function_nonexistent_class.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/create_function_nonexistent_db.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/create_function_nonudf_class.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/database_drop_not_empty.q.out 6ccf95a 
>   ql/src/test/results/clientnegative/database_drop_not_empty_restrict.q.out 
> c8275af 
>   ql/src/test/results/clientnegative/drop_func_nonexistent.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/create_func1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/show_functions.q.out 3400ac2 
> 
> Diff: https://reviews.apache.org/r/17494/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Dere
> 
>

Reply via email to