----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18184/#review34783 -----------------------------------------------------------
ql/src/gen/vectorization/ExpressionTemplates/DecimalColumnUnaryFunc.txt <https://reviews.apache.org/r/18184/#comment65070> format comment better (blank after //, blank line before first comment line) ql/src/gen/vectorization/ExpressionTemplates/DecimalColumnUnaryFunc.txt <https://reviews.apache.org/r/18184/#comment65066> I think you could speed this up with an array fill operation for outputIsNull before the loop, but that is a nice-to-have and not essential. ql/src/gen/vectorization/ExpressionTemplates/DecimalColumnUnaryFunc.txt <https://reviews.apache.org/r/18184/#comment65071> remove trailing white space ql/src/gen/vectorization/ExpressionTemplates/DecimalColumnUnaryFunc.txt <https://reviews.apache.org/r/18184/#comment65073> remove trailing white space ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java <https://reviews.apache.org/r/18184/#comment65132> Please add comment to explain what method does. ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java <https://reviews.apache.org/r/18184/#comment65136> delete trailing white space ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java <https://reviews.apache.org/r/18184/#comment65137> delete trailing white space ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java <https://reviews.apache.org/r/18184/#comment65138> fix comment format ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java <https://reviews.apache.org/r/18184/#comment65139> remove trailing white space ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java <https://reviews.apache.org/r/18184/#comment65140> remove trailing white space ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestDecimalUtil.java <https://reviews.apache.org/r/18184/#comment65144> please add cases for non-zero values close to 0 like -0.3 and 0.3 for floor and ceiling ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestDecimalUtil.java <https://reviews.apache.org/r/18184/#comment65147> Please add test to negate 0 and make sure you still get 0 ql/src/test/queries/clientpositive/vector_decimal_math_funcs.q <https://reviews.apache.org/r/18184/#comment65148> please remove trailing white space in .q file (several locations) - Eric Hanson On Feb. 17, 2014, 9:05 a.m., Jitendra Pandey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18184/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2014, 9:05 a.m.) > > > Review request for hive and Eric Hanson. > > > Bugs: HIVE-6416 > https://issues.apache.org/jira/browse/HIVE-6416 > > > Repository: hive-git > > > Description > ------- > > Vectorized mathematical functions for decimal type. > > > Diffs > ----- > > ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 1b76fc9 > common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java 2e0f058 > ql/src/gen/vectorization/ExpressionTemplates/DecimalColumnUnaryFunc.txt > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java > f69bfc0 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DecimalUtil.java > 589450f > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSign.java 628f06d > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAbs.java > 1c1bcfe > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCeil.java > ceb56bb > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFloor.java > a95a263 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNegative.java > f355a82 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRound.java > 5cc8025 > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestDecimalUtil.java > PRE-CREATION > ql/src/test/queries/clientpositive/vector_decimal_math_funcs.q PRE-CREATION > ql/src/test/results/clientpositive/vector_decimal_math_funcs.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/18184/diff/ > > > Testing > ------- > > > Thanks, > > Jitendra Pandey > >
