----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16951/#review34302 -----------------------------------------------------------
Ship it! Looks good, thanks for all the changes! :) - Sushanth Sowmyan On Feb. 6, 2014, 7:19 p.m., Satish Mittal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16951/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2014, 7:19 p.m.) > > > Review request for hive and Sushanth Sowmyan. > > > Repository: hive-git > > > Description > ------- > > - Attaching the patch that implements the functionality to support custom > location for external tables in dynamic partitioning. > > > Diffs > ----- > > > hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatConstants.java > 2ee50b3 > > hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputCommitterContainer.java > a5ae1be > > hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java > 288b7a3 > > hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/HCatFileUtil.java > PRE-CREATION > > hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/HCatOutputFormat.java > 78e77e8 > > hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/OutputJobInfo.java > b63bdc2 > > hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/HCatMapReduceTest.java > 77bdb9d > > hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatDynamicPartitioned.java > d8b69c2 > > hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatExternalDynamicPartitioned.java > 36c7945 > > Diff: https://reviews.apache.org/r/16951/diff/ > > > Testing > ------- > > - Added unit test. > - Tested the functionality through a sample MR program that uses > HCatOutputFormat interface configured with the new custom dynamic location. > > > Thanks, > > Satish Mittal > >
