----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17939/#review34211 -----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java <https://reviews.apache.org/r/17939/#comment64228> Sorry, didn't think of this in last review and comment about it - isUserAdmin is not used from rest of hive code, and I don't see it being used from there. I think we should not add it to the interface. It should be just a package private method in SQLAccessController. trunk/ql/src/test/results/clientpositive/authorization_set_show_current_role.q.out <https://reviews.apache.org/r/17939/#comment64226> there seems to be a problem here . The type for 'set role' is SHOW_ROLES. That does not seem to be related to this change. Can you please open another jira for that ? - Thejas Nair On Feb. 11, 2014, 6:41 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17939/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2014, 6:41 p.m.) > > > Review request for hive. > > > Bugs: HIVE-5944 > https://issues.apache.org/jira/browse/HIVE-5944 > > > Repository: hive > > > Description > ------- > > authorize role ops > > > Diffs > ----- > > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1567278 > trunk/itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java > 1567278 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessControlException.java > 1567278 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java > 1567278 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java > 1567278 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java > 1567278 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java > 1567278 > > trunk/ql/src/test/queries/clientnegative/authorization_create_role_no_admin.q > PRE-CREATION > trunk/ql/src/test/queries/clientnegative/authorization_drop_role_no_admin.q > PRE-CREATION > trunk/ql/src/test/queries/clientnegative/authorization_role_cycles1.q > 1567278 > trunk/ql/src/test/queries/clientnegative/authorization_role_cycles2.q > 1567278 > > trunk/ql/src/test/queries/clientnegative/authorization_show_roles_no_admin.q > PRE-CREATION > trunk/ql/src/test/queries/clientpositive/authorization_1_sql_std.q 1567278 > trunk/ql/src/test/queries/clientpositive/authorization_role_grant1.q > 1567278 > > trunk/ql/src/test/queries/clientpositive/authorization_set_show_current_role.q > 1567278 > > trunk/ql/src/test/results/clientnegative/authorization_create_role_no_admin.q.out > PRE-CREATION > > trunk/ql/src/test/results/clientnegative/authorization_drop_role_no_admin.q.out > PRE-CREATION > trunk/ql/src/test/results/clientnegative/authorization_role_cycles1.q.out > 1567278 > trunk/ql/src/test/results/clientnegative/authorization_role_cycles2.q.out > 1567278 > > trunk/ql/src/test/results/clientnegative/authorization_show_roles_no_admin.q.out > PRE-CREATION > trunk/ql/src/test/results/clientpositive/authorization_1_sql_std.q.out > 1567278 > trunk/ql/src/test/results/clientpositive/authorization_role_grant1.q.out > 1567278 > > trunk/ql/src/test/results/clientpositive/authorization_set_show_current_role.q.out > 1567278 > > Diff: https://reviews.apache.org/r/17939/diff/ > > > Testing > ------- > > Added new tests. > > > Thanks, > > Ashutosh Chauhan > >
