----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17687/#review34020 -----------------------------------------------------------
metastore/if/hive_metastore.thrift <https://reviews.apache.org/r/17687/#comment63956> Should this be list<String> partitionSpec? Seems like client (if ever) will only be intersted in name of partitions which got dropped. Partition object is quite bulky. metastore/if/hive_metastore.thrift <https://reviews.apache.org/r/17687/#comment63955> Should this default to false? Otherwise, we will send back list of Partition object back to client, which could be huge and in most cases, client is not interested in those. metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java <https://reviews.apache.org/r/17687/#comment63957> I think there is a way to do bulk delete from filesystem. If we fire 10K requests on NN to delete dirs, this will take a while. Plus, we will swamp NN, when not needed. Further, this might us give better atomicity guarantees, than current one. If there is no such api on NN, than lets fire jira on HDFS to request this. metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java <https://reviews.apache.org/r/17687/#comment63958> setNeedResult(false) ? metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java <https://reviews.apache.org/r/17687/#comment63963> Looks like this import is unneeded. Also, it seems like currently bulk deletion is supported only via orm? Are you planning to do bulk deletion via direct sql in subsequent jira ? Asking because since perf is major driver for this work and in past we have seen major diff between direct sql and orm perf. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java <https://reviews.apache.org/r/17687/#comment63959> Shall this commented line be deleted? metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java <https://reviews.apache.org/r/17687/#comment63960> Will be good to add a comment here explaining what detach means and why is it required ? metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java <https://reviews.apache.org/r/17687/#comment63961> Shall this commented line be deleted? ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java <https://reviews.apache.org/r/17687/#comment63962> Do we need both of these two boolean variables? - Ashutosh Chauhan On Feb. 7, 2014, 10:55 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17687/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 10:55 p.m.) > > > Review request for hive, Ashutosh Chauhan and Gunther Hagleitner. > > > Repository: hive-git > > > Description > ------- > > See jira. > > > Diffs > ----- > > metastore/if/hive_metastore.thrift c8b58bd > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 4905be0 > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > bcbb52e > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 377709f > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 4306699 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > e18e13f > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 0715e22 > metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 2e3b6da > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 6998b43 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > f54ae53 > ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java 598be11 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 32831fa > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java e59decc > ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 46f96ce > ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java d13d0b0 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 9f15609 > ql/src/java/org/apache/hadoop/hive/ql/plan/DropTableDesc.java 97f0f72 > > Diff: https://reviews.apache.org/r/17687/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
