----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17859/#review33971 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java <https://reviews.apache.org/r/17859/#comment63826> It's possible the exception doesn't have a cause and therefore we are eating the true exception. This should be throw new ...("msg here", e); ql/src/test/org/apache/hadoop/hive/ql/processors/TestCommandProcessorFactory.java <https://reviews.apache.org/r/17859/#comment63827> Why not add a new test for set role? - Brock Noland On Feb. 7, 2014, 10:22 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17859/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 10:22 p.m.) > > > Review request for hive. > > > Bugs: HIVE-5930 > https://issues.apache.org/jira/browse/HIVE-5930 > > > Repository: hive-git > > > Description > ------- > > Implements set role and show current role functionality. > > > Diffs > ----- > > cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 06c3f6c > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 32831fa > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 9f15609 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 7e69912 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java > 2495c40 > > ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactory.java > 1416c2e > > ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java > e91258a > ql/src/java/org/apache/hadoop/hive/ql/plan/RoleDDLDesc.java 77853c5 > > ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorFactory.java > 0ad2fde > ql/src/java/org/apache/hadoop/hive/ql/processors/HiveCommand.java 280d94e > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java > 008efb1 > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java > 632901e > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerFactory.java > c004105 > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java > 172746e > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java > 5c5d0e5 > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactory.java > 7688bbf > > ql/src/test/org/apache/hadoop/hive/ql/processors/TestCommandProcessorFactory.java > 732897f > ql/src/test/queries/clientpositive/authorization_set_show_current_role.q > PRE-CREATION > > ql/src/test/results/clientpositive/authorization_set_show_current_role.q.out > PRE-CREATION > > service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java > d00db1c > > Diff: https://reviews.apache.org/r/17859/diff/ > > > Testing > ------- > > New test case is added. > > > Thanks, > > Ashutosh Chauhan > >
