> On Feb. 4, 2014, 9:23 a.m., Gunther Hagleitner wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g, line 1935 > > <https://reviews.apache.org/r/17691/diff/1/?file=463839#file463839line1935> > > > > i thought multiple ctes are comma separated, no?
we are already using parentheses to wrap the query, comma is not needed > On Feb. 4, 2014, 9:23 a.m., Gunther Hagleitner wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 8992 > > <https://reviews.apache.org/r/17691/diff/1/?file=463841#file463841line8992> > > > > shouldn't views/ctesExpanded be sets? it needs order; viewsExpanded working the same way.... - Harish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17691/#review33573 ----------------------------------------------------------- On Feb. 4, 2014, 10:56 p.m., Harish Butani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17691/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 10:56 p.m.) > > > Review request for hive and Gunther Hagleitner. > > > Bugs: HIVE-1180 > https://issues.apache.org/jira/browse/HIVE-1180 > > > Repository: hive-git > > > Description > ------- > > Support Common Table Expressions (CTEs) in Hive > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 17f3552 > ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java 3fbe8e2 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 59987e3 > > ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java > 4ac8f07 > ql/src/test/queries/clientnegative/cte_recursion.q PRE-CREATION > ql/src/test/queries/clientnegative/cte_with_in_subquery.q PRE-CREATION > ql/src/test/queries/clientpositive/cte_1.q PRE-CREATION > ql/src/test/queries/clientpositive/cte_2.q PRE-CREATION > ql/src/test/results/clientnegative/authorization_invalid_priv_v1.q.out > 431f16e > ql/src/test/results/clientnegative/cte_recursion.q.out PRE-CREATION > ql/src/test/results/clientnegative/cte_with_in_subquery.q.out PRE-CREATION > ql/src/test/results/clientpositive/cte_1.q.out PRE-CREATION > ql/src/test/results/clientpositive/cte_2.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/17691/diff/ > > > Testing > ------- > > added new tests > > > Thanks, > > Harish Butani > >
