[ https://issues.apache.org/jira/browse/HIVE-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891004#comment-13891004 ]
Sushanth Sowmyan commented on HIVE-5814: ---------------------------------------- I've reviewed HIVE-5814.5.patch as a diff on the original HIVE-5814.patch that I reviewed last week, and it looks good to me. I must admit to being slightly nervous about the comments you made about java.sql.Date being weird, having not experimented with it myself, and would like to understand what other corner cases exist, and whether we want to make any changes to other serdes about this. Also, we should take on a documentation task to update the HCat wiki with the Out-of-range semantics. For this patch itself, though, I'm +1. > Add DATE, TIMESTAMP, DECIMAL, CHAR, VARCHAR types support in HCat > ----------------------------------------------------------------- > > Key: HIVE-5814 > URL: https://issues.apache.org/jira/browse/HIVE-5814 > Project: Hive > Issue Type: New Feature > Components: HCatalog > Affects Versions: 0.12.0 > Reporter: Eugene Koifman > Assignee: Eugene Koifman > Attachments: HCat-Pig Type Mapping Hive 0.13.pdf, HIVE-5814.2.patch, > HIVE-5814.3.patch, HIVE-5814.4.patch, HIVE-5814.5.patch > > > Hive 0.12 added support for new data types. Pig 0.12 added some as well. > HCat should handle these as well. Also note that CHAR was added recently. -- This message was sent by Atlassian JIRA (v6.1.5#6160)