[ https://issues.apache.org/jira/browse/HIVE-5959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13886254#comment-13886254 ]
Brock Noland commented on HIVE-5959: ------------------------------------ It looks like we are moving quite a bit a code around. I don't see why we cannot do it in this jira? It's trivial... {noformat} + } catch (Exception e) { + assert (e instanceof RuntimeException); + throw (RuntimeException) e; + } {noformat} This code is completely bad on many levels. * If there is any possibility that a non-RTE can be thrown, then this code is completely wrong. Specifically if a non-RTE can be thrown then it's event worse than just ugly code because depending on if assertions are enabled or not, the *type* of the exception is eaten or the message and stack trace are eaten. * If there is no possibility that non-RTE can be thrown then the catch should be RTE in which case it's immediately re-thrown and this code is completely useless. > SQL std auth - bootstrap SUPERUSER, PUBLIC roles > ------------------------------------------------ > > Key: HIVE-5959 > URL: https://issues.apache.org/jira/browse/HIVE-5959 > Project: Hive > Issue Type: Sub-task > Components: Authorization > Reporter: Thejas M Nair > Assignee: Ashutosh Chauhan > Attachments: HIVE-5959.2.patch, HIVE-5959.3.patch, HIVE-5959.5.patch, > HIVE-5959.6.patch, HIVE-5959.7.patch, HIVE-5959.patch > > Original Estimate: 72h > Remaining Estimate: 72h > > SUPERUSER and PUBLIC are two roles that are always present, these need to be > added automatically on metastore startup. This would be similar to creation > of the "default" database from HMSHandler.init(). > A config param in hive-site.xml will be used to specify the list of users who > belong to the SUPERUSER role. > -- This message was sent by Atlassian JIRA (v6.1.5#6160)