----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17441/ -----------------------------------------------------------
(Updated Jan. 29, 2014, 12:24 a.m.) Review request for hive and Thejas Nair. Changes ------- Updated patch: * isAssignable() working now. Probably, something wrong I was doing earlier. * Thejas pointed out an api which lists role for an user, used that to improve test. * Briefly discussed with Thejas on sync issue. I think there is no race condition here since, these calls are being made from constructor of HMSHandler. For this reason, I have removed synchronized keyword to avoid confusion. Bugs: HIVE-5959 https://issues.apache.org/jira/browse/HIVE-5959 Repository: hive-git Description ------- Adds concept of root role in Hive. Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 84ee78f conf/hive-default.xml.template 66d22f9 itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestAdminUser.java PRE-CREATION metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58f9957 Diff: https://reviews.apache.org/r/17441/diff/ Testing ------- New junit test added. Thanks, Ashutosh Chauhan