----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17169/#review32471 -----------------------------------------------------------
Ship it! jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java <https://reviews.apache.org/r/17169/#comment61338> Do you think we should refactor into a constant like the other constants in this class, and refer to its length? - Szehon Ho On Jan. 22, 2014, 4:01 a.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17169/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 4:01 a.m.) > > > Review request for hive. > > > Bugs: HIVE-6217 > https://issues.apache.org/jira/browse/HIVE-6217 > > > Repository: hive-git > > > Description > ------- > > See JIRA description. > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java 553722d > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java aabb5cb > > Diff: https://reviews.apache.org/r/17169/diff/ > > > Testing > ------- > > No new test. Test suit passed. > > > Thanks, > > Xuefu Zhang > >
