[ 
https://issues.apache.org/jira/browse/HIVE-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867602#comment-13867602
 ] 

Viraj Bhat commented on HIVE-5260:
----------------------------------

Hi Brock,
  Sorry for getting back to you late on this. Thanks for cleaning the code on 
this one.
I think during the merge of the HBaseStorageHandler, some of the code might 
have got copied in 2 places, before I created a function for it. 
So it is redundant to call: _addHBaseResources_ in 331 which in turn calls 
later calls _HBaseConfiguration.addHbaseResources_ and also do the same while 
configuring both input and output job properties.
You can remove line 345. I think this is a typo.
Viraj


> Introduce HivePassThroughOutputFormat that allows Hive to use general purpose 
> OutputFormats instead of HiveOutputFormats in StorageHandlers
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-5260
>                 URL: https://issues.apache.org/jira/browse/HIVE-5260
>             Project: Hive
>          Issue Type: Sub-task
>          Components: HBase Handler, HCatalog
>    Affects Versions: 0.12.0
>            Reporter: Sushanth Sowmyan
>            Assignee: Viraj Bhat
>             Fix For: 0.12.0
>
>         Attachments: HIVE-5260.2.patch, HIVE-5260.patch
>
>
> This is a task being created to address the hive-side of HIVE-4331.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to